-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow dataarrays and preserve dtype in rad2temp #203
Allow dataarrays and preserve dtype in rad2temp #203
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
==========================================
+ Coverage 89.27% 90.00% +0.72%
==========================================
Files 23 23
Lines 2545 2580 +35
==========================================
+ Hits 2272 2322 +50
+ Misses 273 258 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I love how much you could just delete from the original code 😂
Closes #201 |
Closes pytroll/satpy#2613 |
This PR allow xarray's dataarrays to be passe to radiance to temperature conversions, and also makes these functions preserve dtype.
pytest pyspectral
flake8 pyspectral