Update the solar spectrum code to use the included reference spectra #202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, the
SolarIrradianceSpectrum
class requires the user to enter the filename to the solar spectra they wish to use.However,
Pyspectral
comes with a data file containing a solar spectra (2000 ASTM Standard Extraterrestrial Spectrum Reference E-490-00).This PR updates the class to use the included spectra by default (i.e: In the case that the user does not supply their own via the
filename
argument. I have also updated the__init__
docstring to make clear that this spectra is used by default.