Add RSR reader for the EPIC instrument onboard DSCOVR #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #200 +/- ##
=======================================
Coverage 89.27% 89.27%
=======================================
Files 23 23
Lines 2545 2545
=======================================
Hits 2272 2272
Misses 273 273
Flags with carried forward coverage won't be shown. Click here to find out more.
|
adybbroe
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
LGTM! Many thanks. Just one comment that I also want your view on?
Maybe @rolle-at-work , @mraspaud and others have an opinion as well here?
Signed-off-by: Adam.Dybbroe <[email protected]>
adybbroe
reviewed
Oct 20, 2023
There was a problem hiding this comment.
I am testing off line @simonrp84 and get some errors.
First I think we need to rename the hdf5 file to rsr_epic_DSCOVR.h5
WMO Oscar says "DSCOVR" for the satellite
adybbroe
requested changes
Oct 20, 2023
|
OK, have done all the above - should be better now :) |
Now with normalized RSR responses for epic on DISCOVR Signed-off-by: Adam.Dybbroe <[email protected]>
adybbroe
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a conversion script for spectral response functions for the EPIC instrument aboard the DSCOVR satellite.
It converts the excel file with RSR data into an HDF5 file suitable for pyspectral.