Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add aws_c5_18xlarge #980

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

clumsy
Copy link
Contributor

@clumsy clumsy commented Nov 27, 2024

Adding a GPU-less AWS instance type for compute-intensive workloads, e.g. dataset pre-processing and inference.

https://aws.amazon.com/ec2/instance-types/c5

Adding only one of the high end specs, but can add others if needed.

Test plan:

================================================================== test session starts ==================================================================
platform darwin -- Python 3.12.4, pytest-7.4.4, pluggy-1.0.0
<REDACTED>
plugins: cov-5.0.0, anyio-3.7.1, typeguard-2.13.3, timeout-2.3.1, xdist-3.6.1
collected 11 items

torchx/specs/test/named_resources_aws_test.py::NamedResourcesTest::test_aws_c5_18xlarge PASSED                                                    [  9%]
...

================================================================== 11 passed in 0.07s ===================================================================

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 27, 2024
@kiukchung kiukchung self-assigned this Nov 27, 2024
@clumsy clumsy force-pushed the feat/aws_c5_18xlarge branch from f261330 to 5d689a8 Compare December 2, 2024 20:28
@clumsy
Copy link
Contributor Author

clumsy commented Dec 2, 2024

I fixed the linter issues, @kiukchung. Please let me know if this PR needs more work. Thanks!

@kiukchung kiukchung merged commit a5f840e into pytorch:main Dec 2, 2024
15 of 22 checks passed
@clumsy clumsy deleted the feat/aws_c5_18xlarge branch December 3, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants