Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add aws_g6e instances #969

Merged
merged 1 commit into from
Nov 26, 2024
Merged

feat: add aws_g6e instances #969

merged 1 commit into from
Nov 26, 2024

Conversation

clumsy
Copy link
Contributor

@clumsy clumsy commented Nov 5, 2024

A new GPU-enabled AWS instance has been added.

More details can be found in the following docs:

Test plan:

  • added new unit test

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 5, 2024
@clumsy
Copy link
Contributor Author

clumsy commented Nov 7, 2024

@d4l3k could you please have a look? Please let me know if any modification is needed, thanks!

@kiukchung
Copy link
Collaborator

@clumsy thanks for adding. LGTM. Could you take a look at the failing Lint? IIRC torchx is integrated with lintrunner so you can lint your changes locally for faster dev velocity. See: https://pypi.org/project/lintrunner/

@clumsy
Copy link
Contributor Author

clumsy commented Nov 7, 2024

Sure, @kiukchung, will address the failures.

@clumsy
Copy link
Contributor Author

clumsy commented Nov 7, 2024

Addressed the linter issues, @kiukchung. I had to bump the pinned pyre-check-nightly version - the currently configured one is no longer available. I picked the oldest available in this PR to address the failure (perhaps we want to remove this constraint altogether?), but let me know if you want me to revert this part of the PR.

ERROR: Could not find a version that satisfies the requirement pyre-check-nightly==0.0.101709640814 (from versions: 0.0.101720869228, ...

@kiukchung
Copy link
Collaborator

thanks. LGTM

@kiukchung
Copy link
Collaborator

@andywag , @yikaiMeta could one of you be so kind to take a look at the pyre and docs build failures and let @clumsy know what the next steps are?

@clumsy
Copy link
Contributor Author

clumsy commented Nov 19, 2024

@andywag, @yikaiMeta Do you have any suggestions? Is the problem fixed so that rebasing fixes the issue? Thanks!

.pyre_configuration Outdated Show resolved Hide resolved
@kiukchung
Copy link
Collaborator

Per HUD:torchx pyre, docs-build and python unittests-3.8 are already broken. I manually validated that:

  1. pyre check passes on the files changed by this PR
  2. doc-build failure is unrelated to this PR
  3. python -m unittest torchx/specs/test/test_named_resources_aws.py passes

Merging this PR.

@kiukchung kiukchung merged commit 26cb186 into pytorch:main Nov 26, 2024
15 of 22 checks passed
@clumsy clumsy deleted the feat/aws_g6e branch November 26, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants