Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create session id and use it in table 'Pytorch Elastic Tsm Log' #953

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

yikaiMeta
Copy link
Contributor

@yikaiMeta yikaiMeta commented Sep 3, 2024

We need to create a unique session ID to identify each torchx run session.

Differential Revision: D62087199

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 3, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62087199

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62087199

yikaiMeta added a commit to yikaiMeta/torchx that referenced this pull request Sep 6, 2024
…rch#953)

Summary:
Pull Request resolved: pytorch#953

Please read the doc to understand why we create the session id: https://docs.google.com/document/d/1WJBrqSHrNIc9J1W_1PMIQPu11y2fV_hU36aeiBTgN90/edit

Differential Revision: D62087199
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62087199

yikaiMeta added a commit to yikaiMeta/torchx that referenced this pull request Sep 8, 2024
…rch#953)

Summary:
Pull Request resolved: pytorch#953

Please read the doc to understand why we create the session id: https://docs.google.com/document/d/1WJBrqSHrNIc9J1W_1PMIQPu11y2fV_hU36aeiBTgN90/edit

Differential Revision: D62087199
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62087199

yikaiMeta added a commit to yikaiMeta/torchx that referenced this pull request Sep 9, 2024
…rch#953)

Summary:
Pull Request resolved: pytorch#953

Please read the doc to understand why we create the session id: https://docs.google.com/document/d/1WJBrqSHrNIc9J1W_1PMIQPu11y2fV_hU36aeiBTgN90/edit

Differential Revision: D62087199
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62087199

yikaiMeta added a commit to yikaiMeta/torchx that referenced this pull request Sep 9, 2024
…rch#953)

Summary:
Pull Request resolved: pytorch#953

Please read the doc to understand why we create the session id: https://docs.google.com/document/d/1WJBrqSHrNIc9J1W_1PMIQPu11y2fV_hU36aeiBTgN90/edit

Differential Revision: D62087199
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62087199

yikaiMeta added a commit to yikaiMeta/torchx that referenced this pull request Sep 9, 2024
…rch#953)

Summary:
Pull Request resolved: pytorch#953

Please read the doc to understand why we create the session id: https://docs.google.com/document/d/1WJBrqSHrNIc9J1W_1PMIQPu11y2fV_hU36aeiBTgN90/edit

Differential Revision: D62087199
yikaiMeta added a commit to yikaiMeta/torchx that referenced this pull request Sep 9, 2024
…rch#953)

Summary:
Pull Request resolved: pytorch#953

Please read the doc to understand why we create the session id: https://docs.google.com/document/d/1WJBrqSHrNIc9J1W_1PMIQPu11y2fV_hU36aeiBTgN90/edit

Differential Revision: D62087199
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62087199

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62087199

yikaiMeta added a commit to yikaiMeta/torchx that referenced this pull request Sep 9, 2024
…rch#953)

Summary:
Pull Request resolved: pytorch#953

Please read the doc to understand why we create the session id: https://docs.google.com/document/d/1WJBrqSHrNIc9J1W_1PMIQPu11y2fV_hU36aeiBTgN90/edit

Differential Revision: D62087199
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62087199

yikaiMeta added a commit to yikaiMeta/torchx that referenced this pull request Sep 9, 2024
…rch#953)

Summary:
Pull Request resolved: pytorch#953

Please read the doc to understand why we create the session id: https://docs.google.com/document/d/1WJBrqSHrNIc9J1W_1PMIQPu11y2fV_hU36aeiBTgN90/edit

Differential Revision: D62087199
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62087199

yikaiMeta added a commit to yikaiMeta/torchx that referenced this pull request Sep 9, 2024
…rch#953)

Summary:
Pull Request resolved: pytorch#953

Please read the doc to understand why we create the session id: https://docs.google.com/document/d/1WJBrqSHrNIc9J1W_1PMIQPu11y2fV_hU36aeiBTgN90/edit

Differential Revision: D62087199
Copy link
Contributor

@andywag andywag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62087199

yikaiMeta added a commit to yikaiMeta/torchx that referenced this pull request Sep 10, 2024
…rch#953)

Summary:
Pull Request resolved: pytorch#953

Please read the doc to understand why we create the session id: https://docs.google.com/document/d/1WJBrqSHrNIc9J1W_1PMIQPu11y2fV_hU36aeiBTgN90/edit

Reviewed By: andywag

Differential Revision: D62087199
…rch#953)

Summary:
Pull Request resolved: pytorch#953

Please read the doc to understand why we create the session id: https://docs.google.com/document/d/1WJBrqSHrNIc9J1W_1PMIQPu11y2fV_hU36aeiBTgN90/edit

Reviewed By: andywag

Differential Revision: D62087199
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62087199

@facebook-github-bot facebook-github-bot merged commit e1eb939 into pytorch:main Sep 10, 2024
20 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants