Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add in_cluster option for KubernetesScheduler #917

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MBHuman
Copy link

@MBHuman MBHuman commented May 28, 2024

Add in_cluster opts to run KubernetesScheduler on pods without ~/.kube/config file where $KUBECONFIG env is "" .

I have problem with my Airflow DAG, after that I implemented my solution to run KubernetesScheduler with volcano without KUBECONFIG

[2024-05-28, 20:13:35 UTC] {warnings.py:110} WARNING - /home/airflow/.local/lib/python3.12/site-packages/torchx/schedulers/kubernetes_scheduler.py:557: UserWarning: failed to load kube config: Invalid kube-config file. No configuration found.

Test plan:

Run on my airflow configuration with cfg

    app_handle = runner.run(component_spec, scheduler="kubernetes", cfg={
        "queue": "queue",
        "in_cluster": True
    })

@facebook-github-bot
Copy link
Contributor

Hi @MBHuman!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 28, 2024
warnings.warn(f"failed to load kube config: {e}")
if self._in_cluster:
try:
config.load_incluster_config(client_configuration=configuration)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to automatically detect this? Maybe we should try the kube_config and then this if KubeConfig doesn't exist via a try-except?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, will try to add it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants