PyTorch Profiler Bug Fix to Load Supplied Directory #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D50370372 |
Summary: Seems to be caused by D47367943, where logdir is always overridden by logdir_spec. This fix will use the first directory in case multiple are provided. Reviewed By: jcarreiro Differential Revision: D50370372
|
This pull request was exported from Phabricator. Differential Revision: D50370372 |
hamzajzmati
force-pushed
the
export-D50370372
branch
from
9df9a86 to
00fd7d0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50370372 |
|
This pull request has been merged in 4d61edd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Seems to be caused by D47367943, where logdir is always overridden by logdir_spec. This fix will use the first directory in case multiple are provided.
Reviewed By: jcarreiro
Differential Revision: D50370372