Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: make normalization of Boolean env vars case-insensitive #10080

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

radoering
Copy link
Member

@radoering radoering commented Jan 20, 2025

Pull Request Check List

See #10066 (comment)

  • Added tests for changed code.
  • Updated documentation for changed code.

Summary by Sourcery

Tests:

  • Added tests for case-insensitive boolean normalization.

Copy link

sourcery-ai bot commented Jan 20, 2025

Reviewer's Guide by Sourcery

This pull request modifies the boolean normalizer to be case-insensitive and to accept '1' and '0' as valid boolean values.

Flow diagram for Boolean environment variable normalization

graph TD
    A[Input String] --> B{Convert to lowercase}
    B --> C{Check value}
    C -->|'true' or '1'| D[Return true]
    C -->|other values| E[Return false]
Loading

File-Level Changes

Change Details Files
Modified the boolean normalizer to be case-insensitive and to accept '1' and '0' as valid boolean values.
  • The boolean normalizer now converts the input to lowercase before checking if it is 'true' or '1'.
src/poetry/config/config.py
Added test cases for case-insensitive boolean values and '1' and '0' as valid boolean values.
  • Added test cases for 'True', 'False', '1', and '0' as valid boolean values.
tests/config/test_config.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @radoering - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please update the documentation to reflect that boolean environment variables now accept case-insensitive values ('true'/'True'/'TRUE', 'false'/'False'/'FALSE') and numeric values ('0', '1').
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@radoering radoering merged commit f907d2d into python-poetry:main Jan 20, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants