-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: adapt tests to cosmetic changes caused by poetry-core#821 #10077
Conversation
Reviewer's Guide by SourceryThis pull request adapts the tests to changes in the way that poetry-core generates marker strings. The changes in poetry-core cause the generated marker strings to be more compact and readable, which requires changes to the expected marker strings in the tests. Class diagram showing poetry-core marker string changesclassDiagram
class MarkerEnvironment {
+generate_marker_string()
}
class TestSolver {
+test_marker_strings()
}
note for MarkerEnvironment "Updated to generate
more compact strings"
note for TestSolver "Adapted test assertions
for new format"
TestSolver ..> MarkerEnvironment: uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @radoering - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
127d9c3
to
2347511
Compare
2347511
to
74d0b4e
Compare
74d0b4e
to
2f577d7
Compare
see issue title
Summary by Sourcery
Tests: