Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: adapt tests to cosmetic changes caused by poetry-core#821 #10077

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

radoering
Copy link
Member

@radoering radoering commented Jan 19, 2025

see issue title

  • Added tests for changed code.
  • Updated documentation for changed code.

Summary by Sourcery

Tests:

Copy link

sourcery-ai bot commented Jan 19, 2025

Reviewer's Guide by Sourcery

This pull request adapts the tests to changes in the way that poetry-core generates marker strings. The changes in poetry-core cause the generated marker strings to be more compact and readable, which requires changes to the expected marker strings in the tests.

Class diagram showing poetry-core marker string changes

classDiagram
    class MarkerEnvironment {
        +generate_marker_string()
    }
    class TestSolver {
        +test_marker_strings()
    }
    note for MarkerEnvironment "Updated to generate
more compact strings"
    note for TestSolver "Adapted test assertions
for new format"
    TestSolver ..> MarkerEnvironment: uses
Loading

File-Level Changes

Change Details Files
Adapt tests to changes in marker string generation.
  • Update expected marker strings in test_solver_duplicate_dependencies_with_overlapping_markers_complex to match the new output from poetry-core.
tests/puzzle/test_solver.py
Update poetry-core dependency to a specific commit.
  • Update the poetry-core dependency to a specific commit in the pyproject.toml file.
  • Update the poetry.lock file to reflect the change in the poetry-core dependency.
pyproject.toml
poetry.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @radoering - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

pyproject.toml Outdated Show resolved Hide resolved
@radoering radoering force-pushed the perf-marker-intersection branch from 2347511 to 74d0b4e Compare January 20, 2025 15:58
@radoering radoering requested a review from abn January 20, 2025 16:12
@radoering radoering force-pushed the perf-marker-intersection branch from 74d0b4e to 2f577d7 Compare January 20, 2025 16:37
@abn abn merged commit ab5afb9 into python-poetry:main Jan 20, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants