Prefer LC_MONETARY when formatting currencies #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1173 +/- ##
==========================================
+ Coverage 91.33% 91.34% +0.01%
==========================================
Files 27 27
Lines 4650 4657 +7
==========================================
+ Hits 4247 4254 +7
Misses 403 403
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Alexis Hildebrandt <[email protected]>
|
I'll take a look later today ;) |
tomasr8
approved these changes
Jan 16, 2025
| else: | ||
| raise TypeError(f"Invalid type for category: {category!r}") | ||
|
|
||
| for name in varnames: |
There was a problem hiding this comment.
This will technically try to look up an empty string now when using default_locale('') or default_locale(['']) but I guess that's a rare-enough case?
| if isinstance(category, str): | ||
| varnames = (category, *varnames) | ||
| elif isinstance(category, (list, tuple)): | ||
| varnames = (*category, *varnames) |
There was a problem hiding this comment.
Should calls like default_locale([None]) work without raising? (os.getenv raises for None)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1051 (supersedes it).