Remove Spectrograph idname() method
#1889
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The base class method raises a NotImplementedError, but only Keck/Deimos actually implements this method -- no other spectrograph does. Since it is unused (and apparently unneeded), remove it from the base class and Keck/Deimos. modified: pypeit/spectrographs/keck_deimos.py modified: pypeit/spectrographs/spectrograph.py
kbwestfall
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base class method raises a
NotImplementedError, but only Keck/Deimos actually implements this method -- no other spectrograph does.All frame types are defined in
pypeit/core/framematch.py, and individual spectrograph classes now match raw frames with types from this list.Since the
idname()method is unused and unneeded, remove it from the base class and Keck/Deimos.