Enable users to run and re-run one step of Calibrations #1877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debora-pe
requested changes
Dec 13, 2024
| @@ -793,7 +865,8 @@ def get_flats(self): | |||
| calib_key = illum_calib_key if pixel_calib_key is None else pixel_calib_key | |||
| setup = illum_setup if pixel_setup is None else pixel_setup | |||
| calib_id = illum_calib_id if pixel_calib_id is None else pixel_calib_id | |||
| if cal_file.exists() and self.reuse_calibs: | |||
|
|
|||
| if cal_file.exists() and self.reuse_calibs and not force == 'remake': | |||
There was a problem hiding this comment.
Is the force=reload option missing here?
There was a problem hiding this comment.
Oof. I forgot how complicated the flat file is...
There was a problem hiding this comment.
I think this is ok..
kbwestfall
requested changes
Dec 18, 2024
| @@ -793,7 +865,8 @@ def get_flats(self): | |||
| calib_key = illum_calib_key if pixel_calib_key is None else pixel_calib_key | |||
| setup = illum_setup if pixel_setup is None else pixel_setup | |||
| calib_id = illum_calib_id if pixel_calib_id is None else pixel_calib_id | |||
| if cal_file.exists() and self.reuse_calibs: | |||
|
|
|||
| if cal_file.exists() and self.reuse_calibs and not force == 'remake': | |||
There was a problem hiding this comment.
Oof. I forgot how complicated the flat file is...
kbwestfall
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A script and related to code to run to one step of the calibrations and stop.
This is mainly useful to re-run a bad calibration step.
Docs included and a test in the DevSuite in an accompanying PR.
Part of the motivation here is to enable a future Dashboard.