HotFix: SkyRegions GUI #1718
Merged
HotFix: SkyRegions GUI #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbwestfall
approved these changes
Nov 2, 2023
pypeit/core/gui/skysub_regions.py
Outdated
| else: | ||
| # Build the master Sky Regions calibration frame | ||
| msskyreg = buildimage.SkyRegions(image=inmask.astype(float), PYP_SPEC=self.spectrograph) | ||
| return msskyreg |
There was a problem hiding this comment.
I think this is a bit clearer:
if not self._use_updates:
return None
# Generate the mask
inmask = skysub.generate_mask(self.pypeline, self._skyreg, self.slits, self.slits_left,
self.slits_right)
if np.all(np.logical_not(inmask)):
msgs.warn("Sky regions are empty - master calibration frame will not be generated")
return None
# Build the master Sky Regions calibration frame
return buildimage.SkyRegions(image=inmask.astype(float), PYP_SPEC=self.spectrograph)
There was a problem hiding this comment.
Agreed - I've made that change!
Yes, we probably should - running now... |
profxj
approved these changes
Nov 3, 2023
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #1718 +/- ##
===========================================
- Coverage 41.04% 41.03% -0.01%
===========================================
Files 190 190
Lines 43714 43724 +10
===========================================
+ Hits 17941 17942 +1
- Misses 25773 25782 +9
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hotfix ensures that the calib key/dir/ID are all stored in the SkyRegions calibrations file. Several errors and bits of code cleanup are also implemented.