Fix launching PowerShell on UNC paths #6322
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Pipenv!
The issue
When using PowerShell in Windows, executing
pipenv shell
inside a UNC path (such as a SMB share) will cause aCMD.EXE
error to be thrown, and a change to an incorrect CWD (normally,C:\Windows
)The fix
By disabling the shell functionality of
subprocess.call
, this is avoided.On Windows, when this parameter is set to true, causes an intermediate
CMD.EXE
to be spawned between Python and PowerShell, which does not support the UNC path, causing the wrong CWD to be presented to the final PowerShell shell.The checklist
news/
directory to describe this fix with the extension.bugfix.rst
,.feature.rst
,.behavior.rst
,.doc.rst
..vendor.rst
. or.trivial.rst
(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.