Fix failing asv benchmarks in CI #2352
Conversation
|
I think builds are broken until this gets fixed. I have no familiarity with the asv performance benchmarks, so I request someone to look at the results and see if they are still legit. Thanks. |
There was a problem hiding this comment.
Nice PR @markcampanelli !! Minor suggestions about the whatsnew.
| * asv 0.4.2 upgraded to asv 0.6.4 to fix CI install failure due to pinned older conda. | ||
| (pull:`2352`) |
There was a problem hiding this comment.
| * asv 0.4.2 upgraded to asv 0.6.4 to fix CI install failure due to pinned older conda. | |
| (pull:`2352`) | |
| * asv 0.4.2 upgraded to asv 0.6.4 to fix CI failure due to pinned older conda. | |
| (pull:`2352`) |
It sounds weird to me; like if it were the CI what you were installing.
In any case, that's not important. Can you move this to the Testing section? Or create a new one called Maintenance? I feel like requirements is more about dependencies an user would normally install.
|
|
||
|
|
||
| Contributors | ||
| ~~~~~~~~~~~~ | ||
| * Mark Campanellli (:ghuser:`markcampanelli`) |
There was a problem hiding this comment.
| * Mark Campanellli (:ghuser:`markcampanelli`) | |
| * Mark Campanelli (:ghuser:`markcampanelli`) |
Hehe.
There was a problem hiding this comment.
Copy pasta strikes again!
|
@echedey-ls Thanks for your review. Comments addressed. This should be ready to merge. |
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.