Raise helpful exceptions for irradiance.gti_dirint #2347
+31
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[] Updates entries indocs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.gti_dirint
could fail for a number of not-well-defined conditions. One known condition is reported in #1342, where all inputs have AOI >= 90.I could not determine exactly how much data is "required" by
gti_dirint
. For instance, if there are insufficient daily data with 60 < AOI < 85 (see these lines), the function will proceed withkt_prime_gte_90= np.nan
and will basically assume that the day is entirely clear at this line. I can't say that's a failure of the code, but I'm skeptical thatgti_dirint
will return anything meaningful. I don't know if we want to check, or what exception or warning to raise.In any case, the check added in this PR closes the issue reported in #1342, and sets up
gti_dirint
to have additional checks added, should that be desired.