Fix table parsing with * in non-table names #1209
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If
iptables-save
contains*
in a non-table names it will break table parsing:*
will be consideredabsent
and will be forcefully added on every puppet run without duplicate checks (cuz puppet thinks that there are no more rules in that table)Additional Context
We need to have more
iptables-save
parsing tests, there are more bugs at rule level as well (i will open PR tomorrow)Checklist
puppet apply
)