-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[image-view] Add scroll support to zoom-in and zoom-out #1197
base: updated-latest-electron
Are you sure you want to change the base?
[image-view] Add scroll support to zoom-in and zoom-out #1197
Conversation
Really excited about this feature idea, and something I've absent-mindedly tried to do way to many times forgetting it doesn't exist. But I do see some test failures here, that I don't necessarily believe are the fault of your code at all, but are ones we don't expect to see, so we will probably want to take a closer look at those sometime soon. @DeeDeeG a ping for whenever your available if you'd like to help look into this. EDIT: Sorry, I missed this was aimed at If you intended to target the dev electron branch, feel free to ignore my above comment. But if you otherwise think this is something that can work now, which seems to me like it could, maybe you can retarget to the |
My pull request introduce scroll zooming, but I think it's not best approach. I will prepare another solutions like this: https://dev.to/stackfindover/zoom-image-point-with-mouse-wheel-11n3. Please wait to check it, I will prepare a new version. |
Summary:
I have tested it with Pulsar and PulsarNext. |
I have tried to change the base branch of the pull request, but there are 200+ commits from the updated-latest-electron branch. How can I change the base branch to avoid this? |
I'd suggest creating a new branch off of |
It's natural to zoom-in and zoom-out images by
Ctrl-Scroll
. It was required to change howzoom-to-fit
works.