Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throttle tree-view watcher #1194

Conversation

asiloisad
Copy link
Contributor

@asiloisad
Copy link
Contributor Author

My problem has been solved. Additionaly, I have moved compare goal to common function to make easier deal with compare goal by community packages, e.g. tree-view-order.

@savetheclocktower
Copy link
Contributor

I have to stop idly wondering out loud, making you do work, then doing something else which makes it unnecessary. :)

Try latest from updated-latest-electron — I felt this was a good opportunity to switch off of pathwatcher for this function. Initial testing seems to work fine, and watchPath already batches filesystem changes.

@savetheclocktower
Copy link
Contributor

That said, I'm happy to move the comparator function to a property the way you've done in this PR — if you open a PR for that change alone I'll accept it.

@asiloisad asiloisad closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants