[tree-view] Fix issue with revealing in finder on macOS…

…by implementing `atom.showItemInFolder` to trigger `shell.showItemInFolder` from the main process.

packages/tree-view/lib/directory.js

@@ -243,9 +243,6 @@ class Directory {
     this.watchSubscription?.dispose()
     this.watchSubscription = null
 
-    this.parentWatchSubscription?.dispose()
-    this.parentWatchSubscription = null
-
     for (let [key, entry] of this.entries) {
       entry.destroy()
       this.entries.delete(key)

packages/tree-view/lib/tree-view.js

@@ -822,7 +822,7 @@ class TreeView {
         `Unable to show ${filePath} in ${this.getFileManagerName()}`
       );
     }
-    return shell.showItemInFolder(filePath);
+    return atom.showItemInFolder(filePath);
   }
 
   showCurrentFileInFileManager() {
@@ -834,7 +834,7 @@ class TreeView {
         `Unable to show ${filePath} in ${this.getFileManagerName()}`
       );
     }
-    return shell.showItemInFolder(filePath);
+    return atom.showItemInFolder(filePath);
   }
 
   getFileManagerName() {

src/application-delegate.js

@@ -146,6 +146,18 @@ module.exports = class ApplicationDelegate {
     });
   }
 
+  showItemInFolder(filePath) {
+    // A simple wrapper around `shell.trashItem`, which currently can only be
+    // called from the main process.
+    return ipcRenderer.invoke('showItemInFolder', filePath).then(({ outcome, error, result }) => {
+      if (outcome === 'success') {
+        return result;
+      } else if (outcome === 'failure') {
+        return Promise.reject(error);
+      }
+    });
+  }
+
   async openWindowDevTools() {
     // Defer DevTools interaction to the next tick, because using them during
     // event handling causes some wrong input events to be triggered on

src/atom-environment.js

@@ -786,6 +786,16 @@ class AtomEnvironment {
     return this.applicationDelegate.trashItem(filePath);
   }
 
+  // A proxy to `shell.showItemInFolder` — which ought to work in the renderer,
+  // but seems to suffer from a bug on macOS. We work around it by delegating
+  // to the main process.
+  //
+  // Undocumented for now, but may eventually be an official part of the API
+  // for when community packages need to perform this function.
+  showItemInFolder(filePath) {
+    return this.applicationDelegate.showItemInFolder(filePath);
+  }
+
   // Restore the window to its previous dimensions and show it.
   //
   // Restores the full screen and maximized state after the window has resized to

src/main-process/atom-application.js

@@ -155,10 +155,22 @@ ipcMain.handle('trashItem', async (_, filePath) => {
     return { outcome: 'success', result };
   } catch (error) {
     // …and rejects on failure.
-    return { outcome: 'failure', error }
+    return { outcome: 'failure', error };
   }
 });
 
+ipcMain.handle('showItemInFolder', async (_, filePath) => {
+  try {
+    // Result will be `undefined`, but might as well return it in case of a
+    // future Electron API change.
+    let result = shell.showItemInFolder(filePath);
+    return { outcome: 'success', result };
+  } catch (error) {
+    // Not sure whether this can even fail, but might as well handle it.
+    return { outcome: 'failure', error };
+  }
+})
+
 // The application's singleton class.
 //
 // It's the entry point into the Pulsar application and maintains the global state