-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moved index2.html to /v2/index.html #458
Conversation
added @popperjs/core for bootstrap 5
test all Fields
@jywarren , please how may I relate the path of these files after moving |
Hi! Take a look at this example! https://github.com/publiclab/infragram/blob/Forchapeatl-patch-13/vr/index.html#L19 |
Add relative paths to assets
Ok I think you need to adjust the test paths too now! |
Good work though!! |
Thank you @jywarren ,Please what should I do about the bootstrap problem? When I includes it shader files(WebGL) do not lot. If I exclude it the UI will get destroyed. I was thinking of including the shader* files in our v2 directory. . |
Ah, sorry i missed that question. See how in these examples, we made the path to those files settable using configuration options? Lines 184 to 185 in 5ff8f3f
That should work! Yes, we encountered this same issue before for those versions! |
Added relative path of shader* files
Thank you @jywarren . May I have permission to merge ? |
@@ -509,7 +509,9 @@ <h6 style="text-decoration:underline;">BLUE filters <i class="fa fa-filter" aria | |||
infragram = Infragram({ | |||
uploader: false, | |||
processor: 'webgl', | |||
version: 2 | |||
version: 2, | |||
shaderVertPath: "../dist/shader.vert", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
Great. Let's be sure @stephaniequintana knows we've moved the file! |
I approved so go ahead!! |
moved index2.html to /v2/index.html
Fixes #418
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
@publiclab/reviewers
for help, in a comment below