Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Open Source Project Template to codebases in incubation #303

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

ericherman
Copy link
Member

Request additional reviews from @janderssonse and @danneleaf - please suggest edits.

@danneleaf
Copy link

I think it looks good ! 👍

codebases/index.html Outdated Show resolved Hide resolved
<div class="cb-detail-info">
<h3>What it is</h3>
<p>A template project containing 'Community Health Files' and relevant checklists.</p>
<p>It's intention is to be a practical starter when releasing a project as Open Source.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p>It's intention is to be a practical starter when releasing a project as Open Source.</p>
<p>Its intention is to be a practical starting configuration when releasing a project as Open Source.</p>

Copy link
Member Author

@ericherman ericherman Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<h3>How we're helping</h3>
<p>We're helping launch the Open Source Project Template development by:</p>
<ul>
<li>Providing feedback on the contents</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li>Providing feedback on the contents</li>
<li>Providing feedback on the content</li>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, "contents" seems correct, as the templates and other files in the repository are specific and can be listed with the ls command, like a table of contents ... we're not talking about something abstract or amorphous like "web content".

@ericherman ericherman force-pushed the add-open-source-project-template branch 3 times, most recently from 6c9452e to f719402 Compare October 23, 2023 08:37
@janderssonse
Copy link

@lgtm , also viewed by @danneleaf and @Ayko1595,

Note: the github-repo description was changed from "get going" to getting started, as suggested.

@ericherman ericherman force-pushed the add-open-source-project-template branch from f719402 to f94604a Compare October 23, 2023 11:39
@ericherman ericherman marked this pull request as ready for review October 23, 2023 11:40
@ericherman ericherman requested a review from Ainali October 23, 2023 11:40
@Ainali Ainali merged commit 3099eb7 into develop Oct 23, 2023
2 checks passed
@Ainali Ainali deleted the add-open-source-project-template branch November 7, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants