smartmon.sh: Support sntrealtek device type #206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sntrealtek is a NVMe device behind a Realtek RTL9210 USB to NVMe, output Looks like regular NVMe devices. Signed-off-by: Kjetil Joergensen <[email protected]>
kjetijor
force-pushed
the
smartmon-sh-sntrealtek
branch
from
c3a7427 to
5c14e27
Compare
|
The smartmon.sh script is essentially deprecated and superseded by smartmon.py. Since the smartmon.sh script will be removed at some point in future, do you wish to also add equivalent functionality to smartmon.py? |
|
Having looking briefly at smartmon.py, we wouldn't need to change that, as it uses different heuristics for deciding whether or not to probe a device. If smartmon.sh is "more or less" deprecated, we can probably just close this, and I'll move on to smartmon.py instead of patching on smartmon.sh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sntrealtek is a NVMe device behind a Realtek RTL9210 USB to NVMe, output Looks like regular NVMe devices.