Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial component implementation #3

Merged
merged 1 commit into from
May 13, 2022
Merged

Add initial component implementation #3

merged 1 commit into from
May 13, 2022

Conversation

zugao
Copy link
Collaborator

@zugao zugao commented Apr 29, 2022

This the initial component implementation. At this point in time there are a lot of unknowns due to the fact that the service intself is not ready yet. This PR will be updated as the service is being developed.

Checklist

  • Update the documentation.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@zugao zugao added the enhancement New feature or request label Apr 29, 2022
@zugao zugao marked this pull request as draft April 29, 2022 08:23
@zugao zugao changed the title DRAFT: Add initial component implementation Add initial component implementation Apr 29, 2022
@zugao zugao force-pushed the feature/add-component branch 2 times, most recently from 4a29ecc to f1e1822 Compare April 29, 2022 10:16
@zugao zugao requested review from Kidswiss and ccremer April 29, 2022 11:36
@zugao zugao force-pushed the feature/add-component branch from f1e1822 to d774dc5 Compare April 29, 2022 11:53
ccremer
ccremer reviewed May 2, 2022
View reviewed changes
component/app.jsonnet Outdated Show resolved Hide resolved
component/main.jsonnet Outdated Show resolved Hide resolved
class/defaults.yml Outdated Show resolved Hide resolved
@zugao zugao force-pushed the feature/add-component branch 4 times, most recently from 2e53a80 to aa27a6a Compare May 11, 2022 07:54
ccremer
ccremer reviewed May 11, 2022
View reviewed changes
class/defaults.yml Outdated Show resolved Hide resolved
class/defaults.yml Outdated Show resolved Hide resolved
@zugao zugao force-pushed the feature/add-component branch 3 times, most recently from efa156f to 5b63d2e Compare May 12, 2022 07:30
@zugao zugao requested a review from ccremer May 12, 2022 07:32
@zugao zugao marked this pull request as ready for review May 12, 2022 07:33
@zugao zugao force-pushed the feature/add-component branch from f9266ee to ee7d5c7 Compare May 12, 2022 16:03
ccremer
ccremer suggested changes May 12, 2022
View reviewed changes
class/appcat-service-postgresql.yml Outdated Show resolved Hide resolved
class/defaults.yml Outdated Show resolved Hide resolved
class/defaults.yml Show resolved Hide resolved
docs/modules/ROOT/pages/index.adoc Outdated Show resolved Hide resolved
class/appcat-service-postgresql.yml Outdated Show resolved Hide resolved
class/defaults.yml Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/references/parameters.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/references/parameters.adoc Outdated Show resolved Hide resolved
Kidswiss
Kidswiss requested changes May 13, 2022
View reviewed changes
Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing I found while testing it.

Makefile Show resolved Hide resolved
@zugao zugao requested a review from ccremer May 13, 2022 09:42
@zugao zugao force-pushed the feature/add-component branch from e4b7573 to 94d172b Compare May 13, 2022 09:44
ccremer
ccremer suggested changes May 13, 2022
View reviewed changes
docs/modules/ROOT/pages/tutorials/installation.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/tutorials/installation.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/tutorials/installation.adoc Outdated Show resolved Hide resolved
@zugao zugao force-pushed the feature/add-component branch from 82985e5 to 8918ab0 Compare May 13, 2022 12:42
@zugao zugao requested a review from ccremer May 13, 2022 12:42
@zugao zugao mentioned this pull request May 13, 2022
Merged
2 tasks
ccremer
ccremer reviewed May 13, 2022
View reviewed changes
Copy link
Contributor

@ccremer ccremer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow a suggestion was marked as solved but it's not actually applied? (and I can't unresolve it for some reason...)

docs/modules/ROOT/pages/references/parameters.adoc Outdated Show resolved Hide resolved
@zugao zugao requested a review from ccremer May 13, 2022 12:55
@zugao zugao force-pushed the feature/add-component branch from 13d4c48 to f975c62 Compare May 13, 2022 13:14
ccremer
ccremer approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@ccremer ccremer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing, then LGTM

docs/modules/ROOT/partials/nav.adoc Outdated Show resolved Hide resolved
@zugao zugao force-pushed the feature/add-component branch from f975c62 to 618352d Compare May 13, 2022 15:18
@zugao zugao force-pushed the feature/add-component branch from a34a7c7 to 5702167 Compare May 13, 2022 15:21
@zugao zugao merged commit e611f4c into master May 13, 2022
@ccremer ccremer deleted the feature/add-component branch June 3, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kidswiss Kidswiss Kidswiss approved these changes

@ccremer ccremer ccremer approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zugao @Kidswiss @ccremer