add ratelimit flag #123
Merged
add ratelimit flag #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarunKoyalwar
requested changes
Jul 20, 2023
tarunKoyalwar
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
lgtm !
$ go run . -rls "hackerone.com=8/1s,chaos.projectdiscovery.io=60/m"
Got RateLimits: {"hackerone.com":"8/1s","chaos.projectdiscovery.io":"60/1m0s"}- just realised that time unit validation can be bypassed (ex: 1000m) so replaced with MaxRateLimitTime
- adds example usage in examples/basic/main.go file
Mzack9999
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
lgtm!
We will need to find an easy way for the app using goflags to specify also a list of accepted keys that we will use for validation at runtime (similarly to enum) to avoid user typos (especially for long names). Maybe shall we track this in a follow up ticket?
Open
|
@Mzack9999 Make sense. I opened an issue to track it #125. Feel free to edit/update. |
ehsandeep
added
the
Type: Maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #122.