feat: copa-action initial #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
ashnamehrotra
force-pushed
the
copa-action-initial
branch
4 times, most recently
from
a3d6523 to
afea456
Compare
sozercan
reviewed
Jun 13, 2023
sozercan
reviewed
Jun 13, 2023
sozercan
requested changes
Jun 13, 2023
sozercan
reviewed
Jun 13, 2023
sozercan
reviewed
Jun 13, 2023
sozercan
reviewed
Jun 13, 2023
ashnamehrotra
force-pushed
the
copa-action-initial
branch
from
0b105cc to
9d40693
Compare
ashnamehrotra
force-pushed
the
copa-action-initial
branch
from
8b4178c to
89f70f9
Compare
Signed-off-by: ashnamehrotra <[email protected]>
ashnamehrotra
force-pushed
the
copa-action-initial
branch
3 times, most recently
from
ccc99b0 to
f247bcd
Compare
Signed-off-by: ashnamehrotra <[email protected]>
ashnamehrotra
force-pushed
the
copa-action-initial
branch
from
f247bcd to
3d97522
Compare
Signed-off-by: ashnamehrotra <[email protected]>
ashnamehrotra
force-pushed
the
copa-action-initial
branch
from
f459074 to
b9cf670
Compare
Signed-off-by: ashnamehrotra <[email protected]>
ashnamehrotra
force-pushed
the
copa-action-initial
branch
from
9c57acc to
d339ff3
Compare
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
ashnamehrotra
force-pushed
the
copa-action-initial
branch
from
e814b2a to
a98374d
Compare
Signed-off-by: ashnamehrotra <[email protected]>
ashnamehrotra
force-pushed
the
copa-action-initial
branch
2 times, most recently
from
e5a2f40 to
a39252e
Compare
Signed-off-by: ashnamehrotra <[email protected]>
ashnamehrotra
force-pushed
the
copa-action-initial
branch
from
a39252e to
1297a8a
Compare
sozercan
reviewed
Aug 4, 2023
.github/workflows/build.yaml
Outdated
|
|
||
| - name: Bats Test | ||
| run: | | ||
| docker run --net=host --detach --rm --privileged -p 127.0.0.1:8888:8888 --name buildkitd --entrypoint buildkitd moby/buildkit:v0.12.0 --addr tcp://0.0.0.0:8888 |
There was a problem hiding this comment.
can we make buildkit version an env so it'll be easier to update
sozercan
reviewed
Aug 4, 2023
entrypoint.sh
Outdated
| old_tag=$(echo "$image" | cut -d':' -f2) | ||
|
|
||
| # new patched image tag | ||
| new_tag="$old_tag$patched_tag" |
There was a problem hiding this comment.
what do you think about just specifying a new tag instead of appending? this way user can specify anything
sozercan
reviewed
Aug 4, 2023
|
@ashnamehrotra thanks! added a few minor comments/questions, otherwise LGTM |
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial PR for copa github action integration.