Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rethinkdns: Mention that the app supports Wireguard and Orbot configs #2612

Merged
merged 1 commit into from
Jun 11, 2024
Merged

rethinkdns: Mention that the app supports Wireguard and Orbot configs #2612

merged 1 commit into from
Jun 11, 2024

Conversation

redoomed1
Copy link
Member

@redoomed1 redoomed1 commented Jun 9, 2024 •
edited
Loading

Changes proposed in this PR:

  • Android Overview
    • Remove mention of RethinkDNS from the following sentence (for the reason, see the next section on the changes to the RethinkDNS recommendation):

      RethinkDNS, TrackerControl and AdAway in non-root mode will take up the VPN slot (by using a local loopback VPN) preventing you from using privacy enhancing services such as Orbot or a real VPN server.

    • Add internal link to Orbot card
    • Reword two sections for increased clarity
    • Make minor grammar changes otherwise not noted above
  • DNS Resolvers
    • Mention that RethinkDNS supports Wireguard and Orbot configurations in the app and link documentation for both
      • This renders the part of the quoted statement about RethinkDNS preventing you from using Orbot or a VPN incorrect.
    • Reword RethinkDNS description for improved readability
    • Modify GitHub releases link for Control D so that it no longer points to a specific release tag
  • I agree to the terms listed below:
    Contribution terms (click to expand) 1) I am the sole author of this work. 2) I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project. 3) I have disclosed any relevant conflicts of interest in my post. 4) I agree to the Community Code of Conduct.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2024 •
edited
Loading

✅ Your preview is ready!

Name Link
🔨 Latest commit de9ab91
😎 Preview https://2612--glowing-salamander-8d7127.netlify.app/

dngray
dngray approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@dngray dngray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@redoomed1 @dngray
update: Update to RethinkDNS, Orbot
de9ab91 
- Updates to RethinkDNS and Orbot in the Android overview
- Grammar and typo fixes

Signed-off-by: Daniel Gray <[email protected]>
@dngray dngray merged commit de9ab91 into privacyguides:main Jun 11, 2024
8 checks passed
@dngray dngray added c:software self-hosted/decentralized software and related topics t:correction content corrections or errors labels Jun 11, 2024
dngray pushed a commit that referenced this pull request Jun 11, 2024
@redoomed1 @dngray
update: Update to RethinkDNS, Orbot (#2612)
a5a2ed0 
- Updates to RethinkDNS and Orbot in the Android overview
- Grammar and typo fixes

Signed-off-by: Daniel Gray <[email protected]>
@redoomed1 redoomed1 deleted the rethinkdns-wg-orbot branch June 14, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dngray dngray dngray approved these changes

Assignees
No one assigned
Labels
c:software self-hosted/decentralized software and related topics t:correction content corrections or errors
Projects
PR Review Status
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@redoomed1 @dngray