fix: Remove broken invidious embeds #2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Your preview is ready!
|
|
We should probably investigate to see if these can be fixed first before reverting. |
freddy-m
changed the title
friadev
changed the title
jonaharagon
approved these changes
Aug 2, 2024
|
I don't think this can be fixed long-term, following Google's changes to YouTube around July 7th. |
redoomed1
requested changes
Aug 2, 2024
There was a problem hiding this comment.
I think the presentation of the YouTube links here should be consistent with the way they're presented here: https://www.privacyguides.org/en/advanced/tor-overview/#additional-resources
There are also advantages of signaling that these are YouTube videos rather than embedding them in-text:
- Indicating the link is a YouTube link avoids surprising readers in case they don't mouse over the link for the browser tooltip or long-press on the link on mobile
- As a corollary, it gives readers the freedom of using a YouTube frontend once they see that it's a YouTube link.
redoomed1
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
LGTM
(Also, sorry for the branch merge, I should've rebased first to avoid a merge conflict 😔 )
Signed-off-by: Jonah Aragon <[email protected]> Signed-off-by: redoomed1 <[email protected]>
jonaharagon
force-pushed
the
Pr-invidious
branch
from
726a9c0 to
c0481d6
Compare
|
This pull request has been mentioned on Privacy Guides. There might be relevant details there: |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
One of the videos doesn’t even seem to be available anymore. I felt the best way to simplify and prevent future breakage is to just link to the original YouTube video instead of embedding it.
Closes #2564
Contribution terms (click to expand)
1) I am the sole author of this work. 2) I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project. 3) I have disclosed any relevant conflicts of interest in my post. 4) I agree to the Community Code of Conduct.