Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "this section is new" admonitions to be in line with newer sections #2456

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Remove "this section is new" admonitions to be in line with newer sections #2456

merged 1 commit into from
Mar 30, 2024

Conversation

friadev
Copy link
Contributor

@friadev friadev commented Mar 29, 2024 •
edited
Loading

Changes proposed in this PR:

  • removed "this section is new" admonitions since newly added sections and multiple other older ones
  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

@friadev friadev marked this pull request as ready for review March 29, 2024 23:24
@friadev friadev changed the title Remove "this section is new" admonitions to be in line with newer sections added which don't have them Remove "this section is new" admonitions to be in line with newer sections Mar 29, 2024
@friadev friadev temporarily deployed to preview-netlify March 29, 2024 23:25 — with GitHub Actions Inactive
@netlify Netlify
Copy link

netlify bot commented Mar 29, 2024 •
edited
Loading

✅ Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit d050d27
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/6607a55699c7020008c5a7ca
😎 Deploy Preview https://deploy-preview-2456.preview.privacyguides.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 4 paths audited
Performance: 71 (🔴 down 5 from production)
Accessibility: 91 (🔴 down 1 from production)
Best Practices: 81 (🔴 down 17 from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 29, 2024 •
edited
Loading

This is a test 👀 https://d050d27767d5--glowing-salamander-8d7127.netlify.app/

@friadev @dngray
Remove "this section is new" admonitions (#2456)
d050d27 
Signed-off-by: Daniel Gray <[email protected]>
Signed-off-by: Jonah Aragon <[email protected]>
@dngray dngray merged commit d050d27 into privacyguides:main Mar 30, 2024
14 of 15 checks passed
@dngray dngray temporarily deployed to preview-netlify March 30, 2024 05:40 — with GitHub Actions Inactive
@friadev friadev deleted the pr-remove-new branch March 30, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dngray dngray dngray approved these changes

@jonaharagon jonaharagon jonaharagon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@friadev @jonaharagon @dngray