Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTML for admonitions #2367

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Use HTML for admonitions #2367

merged 1 commit into from
Jan 15, 2024

Conversation

jonaharagon
Copy link
Member

Changes proposed in this PR:

  • potential fix for crowdin issues
  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

Copy link

netlify bot commented Jan 15, 2024

Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit 7ebe767
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/65a5a328bc536d0008e2793c
😎 Deploy Preview https://deploy-preview-2367.preview.privacyguides.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
4 paths audited
Performance: 76 (🟢 up 2 from production)
Accessibility: 91 (🔴 down 1 from production)
Best Practices: 98 (no change from production)
SEO: 88 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

jonaharagon added a commit that referenced this pull request Jan 15, 2024
@jonaharagon jonaharagon force-pushed the jonaharagon/admonition-html branch from c4df350 to 6ffee4e Compare January 15, 2024 06:12
@jonaharagon
Copy link
Member Author

It seems like the only two pages affected by this are device-integrity.md and photo-management.md for now, so what we could do is fix those two pages now by merging this PR, so that we can actually update the site, and then continue this change over time as needed.

No need to do this all at once, I don't think?

@jonaharagon jonaharagon marked this pull request as ready for review January 15, 2024 06:13
@jonaharagon jonaharagon requested a review from dngray January 15, 2024 06:14
@dngray
Copy link
Member

dngray commented Jan 15, 2024

device-integrity.md and photo-management.md for now

No doubt because the other pages went through their old parser.

I think this solution doesn't add too much syntax complexity for contributors, but will mean that the site is not heavily dependent on indentation being just right.

jonaharagon added a commit that referenced this pull request Jan 15, 2024
@jonaharagon jonaharagon force-pushed the jonaharagon/admonition-html branch from 6ffee4e to 133e71b Compare January 15, 2024 21:20
jonaharagon added a commit that referenced this pull request Jan 15, 2024
@jonaharagon jonaharagon force-pushed the jonaharagon/admonition-html branch from 133e71b to 016b939 Compare January 15, 2024 21:26
@jonaharagon jonaharagon force-pushed the jonaharagon/admonition-html branch from 016b939 to 7ebe767 Compare January 15, 2024 21:27
@jonaharagon jonaharagon merged commit 7ebe767 into main Jan 15, 2024
3 checks passed
@jonaharagon jonaharagon deleted the jonaharagon/admonition-html branch January 15, 2024 21:27
@dngray dngray added the t:bug website bugs or errors label Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:bug website bugs or errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants