Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify data breach risk with OAuth #2326

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Clarify data breach risk with OAuth #2326

merged 1 commit into from
Nov 13, 2023

Conversation

dngray
Copy link
Member

@dngray dngray commented Nov 12, 2023

Changes proposed in this PR:

Closes: #2207

  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

@dngray dngray added the t:correction content corrections or errors label Nov 12, 2023
@dngray dngray changed the title Clarify data breach risk with OAuth (#2207) Clarify data breach risk with OAuth Nov 12, 2023
dngray added a commit that referenced this pull request Nov 12, 2023
@dngray dngray requested a review from jonaharagon November 12, 2023 11:27
@dngray dngray added this to the v3.18 milestone Nov 12, 2023
Copy link

netlify bot commented Nov 12, 2023

Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit 1616329
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/6550b68a6018cb0009f1df4f
😎 Deploy Preview https://deploy-preview-2326.preview.privacyguides.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
4 paths audited
Performance: 74 (no change from production)
Accessibility: 91 (🔴 down 1 from production)
Best Practices: 98 (no change from production)
SEO: 88 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 12, 2023

Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit f8570a4
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/655241d1fd42bd0008de83ed
😎 Deploy Preview https://deploy-preview-2326.preview.privacyguides.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
4 paths audited
Performance: 74 (no change from production)
Accessibility: 91 (🔴 down 1 from production)
Best Practices: 98 (no change from production)
SEO: 88 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@jonaharagon
Copy link
Member

jonaharagon commented Nov 13, 2023

I made some changes to incorporate information from #2207 (comment) too, if you could take a look.

@jonaharagon jonaharagon requested a review from freddy-m November 13, 2023 04:59
@dngray
Copy link
Member Author

dngray commented Nov 13, 2023

LGTM i like those changes

dngray added a commit that referenced this pull request Nov 13, 2023
dngray added a commit that referenced this pull request Nov 13, 2023
Signed-off-by: Jonah Aragon <[email protected]>
Signed-off-by: Freddy <[email protected]>
Signed-off-by: Jonah Aragon <[email protected]>
Signed-off-by: Freddy <[email protected]>
@dngray dngray merged commit f8570a4 into main Nov 13, 2023
3 checks passed
@dngray dngray deleted the pr-clarify-oauth branch November 13, 2023 15:33
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/v3-18/15135/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:correction content corrections or errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify data breach risk with OAuth
4 participants