Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Photo Management Recommendations #2102

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Add Photo Management Recommendations #2102

merged 1 commit into from
Nov 13, 2023

Conversation

jonaharagon
Copy link
Member

@jonaharagon jonaharagon commented Mar 23, 2023 •
edited
Loading

Important conflict of interest update, see: #2102 (comment)

  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

@jonaharagon jonaharagon added the c:providers service providers and similar centralized/federated services label Mar 23, 2023
@netlify
Copy link

netlify bot commented Mar 23, 2023 •
edited
Loading

✅ Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit e560812
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/65516c6c4402720008ace839
😎 Deploy Preview https://deploy-preview-2102.preview.privacyguides.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 4 paths audited
Performance: 77 (🟢 up 3 from production)
Accessibility: 91 (🔴 down 1 from production)
Best Practices: 98 (no change from production)
SEO: 88 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@jonaharagon jonaharagon force-pushed the main branch 2 times, most recently from a45aaa2 to 4c805da Compare April 6, 2023 20:53
@ua741
Copy link

ua741 commented Apr 12, 2023

ente-icons.zip

@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/ente-photo-management/11763/14

@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/ente-photo-management/11763/15

@nep2ner
Copy link

nep2ner commented May 9, 2023

It will be awesome to add this category to privacy guides. Immich (self host) should be included for evaluation as well!

@dngray
Copy link
Member

dngray commented May 16, 2023

Might be worth mentioning this https://ente.io/blog/cryptography-audit/ in the ente description now they've done that.

@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/photo-cloud-storage/12883/3

@vishnukvmd
Copy link

Hey @jonaharagon, @dngray, any chance we can merge this PR? It's been a while since we've been approved. I understand you guys are dealing with a ton of work, and it'd be great if we could move forward.

@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/ente-photo-management/11763/31

@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/ente-photos/13692/2

@dngray dngray force-pushed the jonaharagon/photo-management branch 5 times, most recently from 16580c8 to da2024f Compare September 25, 2023 07:11
@ua741
Copy link

ua741 commented Sep 28, 2023

For Cloud based photo management products, that can not be self-hosted, we can borrow points from Cloud Storage section.

Minimum Requirements

  • Must enforce end-to-end encryption.
  • Must offer a free plan or trial period for testing.
  • Must support TOTP or FIDO2 multi-factor authentication, or Passkey logins.
  • Must offer a web interface which supports basic file management functionality.
  • Must allow for easy exports of all files/documents.
  • Must use standard, audited encryption.

@dngray dngray force-pushed the jonaharagon/photo-management branch 2 times, most recently from ed48a80 to cb7e40b Compare October 3, 2023 10:17
@ph00lt0
Copy link
Member

ph00lt0 commented Oct 3, 2023 •
edited
Loading

For Cloud based photo management products, that can not be self-hosted, we can borrow points from Cloud Storage section.

Minimum Requirements

  • Must enforce end-to-end encryption.
  • Must offer a free plan or trial period for testing.
  • Must support TOTP or FIDO2 multi-factor authentication, or Passkey logins.
  • Must offer a web interface which supports basic file management functionality.
  • Must allow for easy exports of all files/documents.
  • Must use standard, audited encryption.

Missing here is audited implementation of encryption. So i would urge to change this into audited by established third party. (Like ente has with Cure53)

@jonaharagon jonaharagon marked this pull request as ready for review October 4, 2023 18:09
@jonaharagon
Copy link
Member Author

I'm recusing myself from this discussion/vote, because ente photos sponsors my employer as of Sept 2023. Some other team member will have to take over getting 2 team approvals other than myself and merging this PR.

@jonaharagon jonaharagon added this to the v3.17 milestone Oct 14, 2023
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/ente-authenticator-2fa/13377/1

@jonaharagon jonaharagon mentioned this pull request Oct 16, 2023
Merged
4 tasks
@jonaharagon jonaharagon modified the milestones: v3.17, v3.18 Nov 1, 2023
jonaharagon
jonaharagon commented Nov 9, 2023
View reviewed changes
Copy link
Member Author

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dngray

docs/photo-management.md Outdated Show resolved Hide resolved
@dngray
Copy link
Member

dngray commented Nov 9, 2023

I think this one is good to go.

dngray added a commit that referenced this pull request Nov 9, 2023
@jonaharagon @dngray
Add Photo Management Recommendations (#2102)
62dc3d3 
Co-authored-by: Daniel Nathan Gray <[email protected]>
@dngray dngray force-pushed the jonaharagon/photo-management branch from 5ecd00b to 62dc3d3 Compare November 9, 2023 07:23
@jonaharagon @dngray
Add Photo Management Recommendations (#2102)
e560812 
Co-authored-by: Daniel Gray <[email protected]>
Signed-off-by: Freddy <[email protected]>
@jonaharagon jonaharagon force-pushed the jonaharagon/photo-management branch from 62dc3d3 to e560812 Compare November 13, 2023 00:23
@jonaharagon jonaharagon merged commit e560812 into main Nov 13, 2023
6 checks passed
@jonaharagon jonaharagon deleted the jonaharagon/photo-management branch November 13, 2023 00:24
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/v3-18/15135/1

@aviv926
Copy link

aviv926 commented Dec 3, 2023

In the announcement on 3.18 it was written that Immich was added, but in practice it is not

@jonaharagon
Copy link
Member Author

Where are you reading that? As far as I know Immich wasn't one we looked at actually, @dngray did you?

@aviv926
Copy link

aviv926 commented Feb 22, 2024

Where are you reading that? As far as I know Immich wasn't one we looked at actually, @dngray did you?

Does it not meet the requirements?

@dngray
Copy link
Member

dngray commented Feb 28, 2024 •
edited
Loading

Immich was not the one we looked at, we looked at ente, stingle and photoprism. I see there is a thread on the forums: https://discuss.privacyguides.net/t/immich-photo-manager-self-hosted/17033 which came after that PR was merged.

@redoomed1 redoomed1 mentioned this pull request Aug 7, 2024
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4rklynk d4rklynk d4rklynk left review comments

@vishnukvmd vishnukvmd vishnukvmd left review comments

@dngray dngray dngray approved these changes

@freddy-m freddy-m freddy-m approved these changes

@blacklight447 blacklight447 Awaiting requested review from blacklight447

Assignees

@freddy-m freddy-m

@dngray dngray

@blacklight447 blacklight447

Labels
c:providers service providers and similar centralized/federated services
Projects
None yet
Milestone
v3.18
Development

Successfully merging this pull request may close these issues.