Skip to content

Commit

Permalink
chore: fix codecov warning
Browse files Browse the repository at this point in the history
  • Loading branch information
@guorong009
guorong009 committed Aug 6, 2024
1 parent 671a802 commit 5d6bfdb
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions halo2_frontend/src/dev/gates.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -338,8 +338,6 @@ mod tests {
impl Circuit<Fp> for TestCircuit {

Check failure on line 338 in halo2_frontend/src/dev/gates.rs

View workflow job for this annotation

GitHub Actions / Clippy (beta)

not all trait items implemented, missing: `Params` 

error[E0046]: not all trait items implemented, missing: `Params`
   --> halo2_frontend/src/dev/gates.rs:338:9
    |
338 |         impl Circuit<Fp> for TestCircuit {
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `Params` in implementation
    |
   ::: halo2_frontend/src/plonk/circuit.rs:251:5
    |
251 |     type Params: Default;
    |     -------------------- `Params` from trait

Check failure on line 338 in halo2_frontend/src/dev/gates.rs

View workflow job for this annotation

GitHub Actions / Clippy (1.56.1)

not all trait items implemented, missing: `Params` 

error[E0046]: not all trait items implemented, missing: `Params`
   --> halo2_frontend/src/dev/gates.rs:338:9
    |
338 |         impl Circuit<Fp> for TestCircuit {
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `Params` in implementation
    |
   ::: halo2_frontend/src/plonk/circuit.rs:251:5
    |
251 |     type Params: Default;
    |     -------------------- `Params` from trait

Check failure on line 338 in halo2_frontend/src/dev/gates.rs

View workflow job for this annotation

GitHub Actions / Test on ubuntu-latest with all features 

not all trait items implemented, missing: `Params`

Check failure on line 338 in halo2_frontend/src/dev/gates.rs

View workflow job for this annotation

GitHub Actions / Test on macOS-latest with all features 

not all trait items implemented, missing: `Params`
type Config = TestCircuitConfig;
type FloorPlanner = SimpleFloorPlanner;
#[cfg(feature = "circuit-params")]
type Params = ();

fn configure(meta: &mut ConstraintSystem<Fp>) -> Self::Config {
let a = meta.advice_column();
Expand Down

0 comments on commit 5d6bfdb

Please sign in to comment.