Skip to content

Merge branch 'main' of github.com:privacy-scaling-explorations/halo2 … #655

Merge branch 'main' of github.com:privacy-scaling-explorations/halo2 …

Merge branch 'main' of github.com:privacy-scaling-explorations/halo2 … #655

Triggered via push June 18, 2024 09:59
Status Success
Total duration 57s
Artifacts

lints-beta.yml

on: push
Clippy (beta)
50s
Clippy (beta)
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 19 warnings
using `clone` on type `Expression<F>` which implements the `Copy` trait: halo2_proofs/examples/circuit-layout.rs#L246
error: using `clone` on type `Expression<F>` which implements the `Copy` trait --> halo2_proofs/examples/circuit-layout.rs:246:35 | 246 | vec![a.clone() * sa + b.clone() * sb + a * b * sm - (c * sc) + sf * (d * e)] | ^^^^^^^^^ help: try removing the `clone` call: `b` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
using `clone` on type `Expression<F>` which implements the `Copy` trait: halo2_proofs/examples/circuit-layout.rs#L246
error: using `clone` on type `Expression<F>` which implements the `Copy` trait --> halo2_proofs/examples/circuit-layout.rs:246:18 | 246 | vec![a.clone() * sa + b.clone() * sb + a * b * sm - (c * sc) + sf * (d * e)] | ^^^^^^^^^ help: try removing the `clone` call: `a` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `-D clippy::clone-on-copy` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::clone_on_copy)]`
using `clone` on type `Expression<Fp>` which implements the `Copy` trait: halo2_frontend/src/dev.rs#L1754
warning: using `clone` on type `Expression<Fp>` which implements the `Copy` trait --> halo2_frontend/src/dev.rs:1754:56 | 1754 | (q.clone() * a, advice_table * s_ltable.clone()), | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `s_ltable` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
using `clone` on type `Expression<Fp>` which implements the `Copy` trait: halo2_frontend/src/dev.rs#L1754
warning: using `clone` on type `Expression<Fp>` which implements the `Copy` trait --> halo2_frontend/src/dev.rs:1754:26 | 1754 | (q.clone() * a, advice_table * s_ltable.clone()), | ^^^^^^^^^ help: try removing the `clone` call: `q` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
using `clone` on type `Expression<Fp>` which implements the `Copy` trait: halo2_frontend/src/dev.rs#L1753
warning: using `clone` on type `Expression<Fp>` which implements the `Copy` trait --> halo2_frontend/src/dev.rs:1753:57 | 1753 | (q.clone() * a.clone(), table * s_ltable.clone()), | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `s_ltable` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
using `clone` on type `Expression<Fp>` which implements the `Copy` trait: halo2_frontend/src/dev.rs#L1753
warning: using `clone` on type `Expression<Fp>` which implements the `Copy` trait --> halo2_frontend/src/dev.rs:1753:38 | 1753 | (q.clone() * a.clone(), table * s_ltable.clone()), | ^^^^^^^^^ help: try removing the `clone` call: `a` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
using `clone` on type `Expression<Fp>` which implements the `Copy` trait: halo2_frontend/src/dev.rs#L1753
warning: using `clone` on type `Expression<Fp>` which implements the `Copy` trait --> halo2_frontend/src/dev.rs:1753:26 | 1753 | (q.clone() * a.clone(), table * s_ltable.clone()), | ^^^^^^^^^ help: try removing the `clone` call: `q` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
using `clone` on type `Expression<Fp>` which implements the `Copy` trait: halo2_frontend/src/dev.rs#L1610
warning: using `clone` on type `Expression<Fp>` which implements the `Copy` trait --> halo2_frontend/src/dev.rs:1610:39 | 1610 | vec![(q.clone() * a.clone(), table), (q * a, advice_table)] | ^^^^^^^^^ help: try removing the `clone` call: `a` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
using `clone` on type `Expression<Fp>` which implements the `Copy` trait: halo2_frontend/src/dev.rs#L1610
warning: using `clone` on type `Expression<Fp>` which implements the `Copy` trait --> halo2_frontend/src/dev.rs:1610:27 | 1610 | vec![(q.clone() * a.clone(), table), (q * a, advice_table)] | ^^^^^^^^^ help: try removing the `clone` call: `q` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
using `clone` on type `Expression<Fp>` which implements the `Copy` trait: halo2_frontend/src/dev.rs#L1533
warning: using `clone` on type `Expression<Fp>` which implements the `Copy` trait --> halo2_frontend/src/dev.rs:1533:49 | 1533 | (q.clone() * a.clone(), s_ltable.clone() * table), | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `s_ltable` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
using `clone` on type `Expression<Fp>` which implements the `Copy` trait: halo2_frontend/src/dev.rs#L1533
warning: using `clone` on type `Expression<Fp>` which implements the `Copy` trait --> halo2_frontend/src/dev.rs:1533:38 | 1533 | (q.clone() * a.clone(), s_ltable.clone() * table), | ^^^^^^^^^ help: try removing the `clone` call: `a` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
using `clone` on type `Expression<Fp>` which implements the `Copy` trait: halo2_frontend/src/dev.rs#L1533
warning: using `clone` on type `Expression<Fp>` which implements the `Copy` trait --> halo2_frontend/src/dev.rs:1533:26 | 1533 | (q.clone() * a.clone(), s_ltable.clone() * table), | ^^^^^^^^^ help: try removing the `clone` call: `q` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `-W clippy::clone-on-copy` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::clone_on_copy)]`
using `clone` on type `Expression<F>` which implements the `Copy` trait: halo2_proofs/examples/circuit-layout.rs#L246
warning: using `clone` on type `Expression<F>` which implements the `Copy` trait --> halo2_proofs/examples/circuit-layout.rs:246:35 | 246 | vec![a.clone() * sa + b.clone() * sb + a * b * sm - (c * sc) + sf * (d * e)] | ^^^^^^^^^ help: try removing the `clone` call: `b` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
using `clone` on type `Expression<F>` which implements the `Copy` trait: halo2_proofs/examples/circuit-layout.rs#L246
warning: using `clone` on type `Expression<F>` which implements the `Copy` trait --> halo2_proofs/examples/circuit-layout.rs:246:18 | 246 | vec![a.clone() * sa + b.clone() * sb + a * b * sm - (c * sc) + sf * (d * e)] | ^^^^^^^^^ help: try removing the `clone` call: `a` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `-W clippy::clone-on-copy` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::clone_on_copy)]`
using `clone` on type `Expression<Fp>` which implements the `Copy` trait: halo2_proofs/examples/proof-size.rs#L42
warning: using `clone` on type `Expression<Fp>` which implements the `Copy` trait --> halo2_proofs/examples/proof-size.rs:42:64 | 42 | let not_selector = Expression::Constant(Fp::ONE) - selector.clone(); | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `selector` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `-W clippy::clone-on-copy` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::clone_on_copy)]`
Clippy (beta)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Clippy (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/