Rails 6 minor + Sprockets Config Update (assets.rb) #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 174
💛 - Coveralls |
masonhensley
commented
Jan 21, 2020
masonhensley
changed the title
gemspec rule for rubyzip compatability with ruby versions less than 2.4 gemfile update via appraisal rm terms_manifest.js from spec/dummy manifest.js Rails 6 Sprockets error in travis updating assets.rb & manifest.js for new sprockets
masonhensley
force-pushed
the
rails-6-minor-travis-fix
branch
from
b8fcc3b to
f8f4e72
Compare
masonhensley
changed the title
|
@patriciojofre @michelson @matipacheco Is there anything we need to change to get this merged? I know it can be a pain in the ass maintaining a repo, so we want to help as much as possible here (and hopefully not be a hindrance). |
|
I think we are ready to merge, just note the change on .update_attributes with .update , is .update compatible with rails 5.1.4 ? Le damos @patriciojofre ? |
|
In Rails 5.1.4 |
|
Can we get this merged in? |
|
Any update on when this is getting merged? |
|
sorry guys, PR merged! thanks for contribute to gdpr rails! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased against #47 (documentation update) and giving a shot at Travis tests to carry the torch on mrsweater's work in #45
Will close #47 if this goes green.
Fixes #44
FYI
Had to update assets.rb & manifest.js to make the latest version of sprockets happy. Was receiving errors like this
Updated Apprisals & Documentation for future contributors
Notes about documentation update:
... Quick documentation update for future contributors based on feedback in #46 & #45
Update
Ready for review. Thanks for the project 🎉