Skip button improvements (#660)

* feat: set default skip button position to topLeft * fix: update test
prebid · Jun 3, 2022 · e1d35ce · e1d35ce
1 parent eeb3f37
commit e1d35ce
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/PrebidMobile/PrebidMobileRendering/AdTypes/AdView/VideoControlsConfiguration.swift b/PrebidMobile/PrebidMobileRendering/AdTypes/AdView/VideoControlsConfiguration.swift
@@ -150,5 +150,5 @@ public class VideoControlsConfiguration: NSObject {
     private var _closeButtonPosition = Position.topRight
 
     private var _skipButtonArea = PBMConstants.BUTTON_AREA_DEFAULT.doubleValue
-    private var _skipButtonPosition = Position.topRight
+    private var _skipButtonPosition = Position.topLeft
 }
diff --git a/PrebidMobileTests/RenderingTests/Tests/PBMVideoViewTest.swift b/PrebidMobileTests/RenderingTests/Tests/PBMVideoViewTest.swift
@@ -286,7 +286,7 @@ class PBMVideoViewTest: XCTestCase, PBMCreativeResolutionDelegate, PBMCreativeVi
         }
 
         XCTAssertEqual(videoView.skipButtonDecorator.buttonArea, 0.1)
-        XCTAssertEqual(videoView.skipButtonDecorator.buttonPosition, .topRight)
+        XCTAssertEqual(videoView.skipButtonDecorator.buttonPosition, .topLeft)
         XCTAssertEqual(videoView.skipButtonDecorator.button.image(for: .normal), UIImage(named: "PBM_skipButton", in: PBMFunctions.bundleForSDK(), compatibleWith: nil))
         XCTAssertEqual(videoView.skipButtonDecorator.button.isHidden, true)
     }

diff --git a/PrebidMobileTests/RenderingTests/Tests/VideoControlsConfigTests.swift b/PrebidMobileTests/RenderingTests/Tests/VideoControlsConfigTests.swift
@@ -44,7 +44,7 @@ class VideoControlsConfigTests: XCTestCase {
 
     func testDefaultSkipButtonPosition() {
         let adConfiguration = VideoControlsConfiguration()
-        XCTAssertEqual(adConfiguration.skipButtonPosition, .topRight)
+        XCTAssertEqual(adConfiguration.skipButtonPosition, .topLeft)
     }
 
     func testDefaultSkipButtonDelay() {