Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: max and min input element types #4568

Merged
merged 1 commit into from
Nov 23, 2024
Merged

fix: max and min input element types #4568

merged 1 commit into from
Nov 23, 2024

Conversation

rschristian
Copy link
Member

Fixes #4566

We had the correct types in the old HTMLAttributes (now AllHTMLAttributes) but in the per-element types I copied from compat seemed to be incorrect.

Will try to write up a script to compare all of our old props to the new, spotting any other discrepancies.

@coveralls
Copy link

Coverage Status

coverage: 99.488%. remained the same
when pulling 5284ada on types/max-min
into 22621b6 on main.

@JoviDeCroock JoviDeCroock merged commit 5b6c3a5 into main Nov 23, 2024
7 checks passed
@JoviDeCroock JoviDeCroock deleted the types/max-min branch November 23, 2024 09:37
@VigilioYonatan
Copy link

when will update version preact package. i need this for my production web. thanks

@rschristian
Copy link
Member Author

We have some other type issues to fix, so in the meantime, please just use // @ts-ignore.

@JoviDeCroock
Copy link
Member

Or @ts-expect-error as that will notify you what to remove after we upgrade the package 😅

@VigilioYonatan
Copy link

VigilioYonatan commented Nov 27, 2024

mi web project is biggest, i use react hook form always. lol . i have too inputs

@JoviDeCroock
Copy link
Member

JoviDeCroock commented Nov 27, 2024

@VigilioYonatan there are many people with big projects, downgrade your version then... This is really impolite, we as maintainers sacrifice our time alongside our day job to help y'all but comments like these are just annoying.

When consumers of packages start demanding a release because their "project is big lol" then why would we sacrifice our time for free?!

@VigilioYonatan
Copy link

Dont worry bro, i will hope. i am going to try to create a d.ts file to fix for a moment

@JoviDeCroock JoviDeCroock mentioned this pull request Dec 1, 2024
@devlux
Copy link
Contributor

devlux commented Dec 7, 2024

@rschristian I think MeterHTMLAttributes and ProgressHTMLAttributes were forgotten

@rschristian
Copy link
Member Author

Not so much forgotten as missed; there's unfortunately no nice list of all standardized attributes. PRs welcome though.

@devlux
Copy link
Contributor

devlux commented Dec 7, 2024

please see #4598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: REACT HOOK FORM register type max input is a number ERROR
5 participants