Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect entries in stream exports #362

Merged
merged 5 commits into from
May 24, 2024
Merged

fix: Incorrect entries in stream exports #362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4b070e3
fix: Ensure streams have valid `.mjs` output modules
rschristian May 24, 2024
0e2a3e2
fix: browser/import export condition order
rschristian May 24, 2024
aa912d2
docs: Add changeset
rschristian May 24, 2024
7e8bd41
fix: Correct stream types
rschristian May 24, 2024
8517ba5
refactor: Drop stream-node "browser" export condition
rschristian May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/large-snakes-share.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'preact-render-to-string': patch
---

Correct stream exports
8 changes: 3 additions & 5 deletions config/node-13-exports.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
const fs = require('fs');

const snakeCaseToCamelCase = str =>
str.replace(/([-_][a-z])/g, group => group.toUpperCase().replace('-', ''));
Comment on lines -3 to -4
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what this was for, but we certainly don't need it


const copy = name => {
const copy = (filename) => {
// Copy .module.js --> .mjs for Node 13 compat.
const filename = name.includes('-') ? snakeCaseToCamelCase(name) : name;
fs.writeFileSync(
`${process.cwd()}/dist/${filename}.mjs`,
fs.readFileSync(`${process.cwd()}/dist/${filename}.module.js`)
Expand All @@ -14,3 +10,5 @@ const copy = name => {

copy('index');
copy('jsx');
copy('stream');
copy('stream-node');
9 changes: 4 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,14 @@
"require": "./dist/jsx.js"
},
"./stream": {
"types": "./stream.d.ts",
"import": "./dist/stream.mjs",
"types": "./dist/stream.d.ts",
"browser": "./dist/stream.module.js",
"import": "./dist/stream.mjs",
"require": "./dist/stream.js"
},
"./stream-node": {
"types": "./stream-node.d.ts",
"types": "./dist/stream-node.d.ts",
"import": "./dist/stream-node.mjs",
"browser": "./dist/stream-node.module.js",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped as it's not suitable for browser use -- it imports from node:stream.

"require": "./dist/stream-node.js"
},
"./package.json": "./package.json"
Expand Down Expand Up @@ -171,4 +170,4 @@
"publishConfig": {
"provenance": true
}
}
}