[issue-730] Upgrade to flink 1.18.1 #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #731 +/- ##
============================================
+ Coverage 81.12% 81.23% +0.11%
- Complexity 573 574 +1
============================================
Files 62 62
Lines 2723 2723
Branches 232 232
============================================
+ Hits 2209 2212 +3
+ Misses 326 324 -2
+ Partials 188 187 -1 ☔ View full report in Codecov by Sentry. |
crazyzhou
reviewed
Feb 4, 2024
| @@ -135,7 +135,7 @@ public void testCreateCatalogFromFactory() { | |||
| assertThat(actualCatalog instanceof PravegaCatalog).isTrue(); | |||
| assertThat(((PravegaCatalog) actualCatalog).getName()).isEqualTo(CATALOG.getName()); | |||
| assertThat(((PravegaCatalog) actualCatalog).getDefaultDatabase()).isEqualTo(CATALOG.getDefaultDatabase()); | |||
| assertThat(Whitebox.getInternalState(actualCatalog, "properties")) | |||
| org.assertj.core.api.Assertions.assertThat((Map) Whitebox.getInternalState(actualCatalog, "properties")) | |||
There was a problem hiding this comment.
We can use assertThat directly
There was a problem hiding this comment.
Hi Brian, the issue has been handled.
| @@ -146,6 +148,21 @@ private static class SinkInitContext implements Sink.InitContext { | |||
| SinkInitContext( | |||
| SinkWriterMetricGroup metricGroup) { | |||
| this.metricGroup = metricGroup; | |||
| } | |||
There was a problem hiding this comment.
Indentation not correct here.
There was a problem hiding this comment.
Hi Brian, The indentation has been fixed.
Hi @crazyzhou , I have made changes and added the references in the description. |
Signed-off-by: root <[email protected]>
Signed-off-by: root <[email protected]>
Signed-off-by: root <[email protected]>
Signed-off-by: root <[email protected]>
Signed-off-by: root <[email protected]>
Signed-off-by: root <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
assertThatPurpose of the change
Fix: #730
What the code does
Upgrade flinkVersion to 1.18.1 in gradle.properties
How to verify it
./gradlew clean build should pass