Fix performance legacy-score command doing things it doesn't need to
#205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not exactly sure when or how this happened because I tested this previously (did some web change cause this?), but the `performance legacy-score` command is: - doubly-applying the classic mod - needlessly marking the score as legacy - incorrectly copying the post-conversion recalculated total score into `LegacyTotalScore` while all it needs to be doing is reading what it is given from the API. All of the data it needs is already there, in a form ready for consumption.
smoogipoo
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not exactly sure when or how this happened because I tested this previously (did some web change cause this?), but the
performance legacy-scorecommand is:LegacyTotalScorewhile all it needs to be doing is reading what it is given from the API. All of the data it needs is already there, in a form ready for consumption.
For instance, see output of
performance legacy-score 215127587 2(see relevant score):master
this PR