Always use window position in UserInputManager
#6440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenzibyte
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Replying to OP, sure the SDL code for returning display bounds on SDL_GetWindowPosition is platform-agnostic, but this doesn't confirm that all platforms will correctly trigger a SDL_EVENT_WINDW_MOVED event. Requesting a double-check on other platforms, macOS is fine on my multi-monitor setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IWindowand remove platform-agnostic code probingISDLWindow#6438 (comment)The window position is updated when
SDL_WINDOWEVENT_MOVEDis sent (which does get sent when changing to fullscreen or borderless) and SDL returns the display position when fullscreen.