a first draft for automated testing of tptp compliance #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test generates the problem files for every strong equivalence example in the res directory and saves them in tests/formatting/tptp/out. Then it invokes the tptp4X tool on each one, and unwraps the result. This causes the test to panic when a file is not tptp-compliant.
The PR could be improved by changing the unwrap panic to an assertion about exit status (although maybe the current method is more direct). Also, it would be nice to clear the "out" directory after every example (see commented code) but that isn't strictly necessary.
This can help us close #161