Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Merge Active and ApIDictEndpoint to ActiveDict #331

Conversation

schloerke
Copy link
Collaborator

Essentially renaming ApiDictEndpoint to ActiveDict.

Note: This means Resource is gone and is now a read-only dictionary

@schloerke schloerke requested a review from tdstein as a code owner November 12, 2024 19:04
@schloerke schloerke changed the title Refactor: Merge Active and ApIDictEndpoint to ActiveDict refactor: Merge Active and ApIDictEndpoint to ActiveDict Nov 12, 2024
Copy link

github-actions bot commented Nov 12, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1916 1820 95% 0% 🟢

New Files

File Coverage Status
src/posit/connect/_content_repository.py 86% 🟢
src/posit/connect/_types_content_item.py 100% 🟢
src/posit/connect/_types_context.py 86% 🟢
src/posit/connect/oauth/_types_context_integration.py 100% 🟢
TOTAL 93% 🟢

Modified Files

File Coverage Status
src/posit/connect/_active.py 92% 🟢
src/posit/connect/_api_call.py 86% 🟢
src/posit/connect/_utils.py 73% 🟢
src/posit/connect/bundles.py 99% 🟢
src/posit/connect/client.py 98% 🟢
src/posit/connect/content.py 96% 🟢
src/posit/connect/env.py 100% 🟢
src/posit/connect/groups.py 59% 🟢
src/posit/connect/jobs.py 100% 🟢
src/posit/connect/me.py 100% 🟢
src/posit/connect/metrics/metrics.py 100% 🟢
src/posit/connect/metrics/shiny_usage.py 100% 🟢
src/posit/connect/metrics/usage.py 100% 🟢
src/posit/connect/metrics/visits.py 100% 🟢
src/posit/connect/oauth/associations.py 98% 🟢
src/posit/connect/oauth/integrations.py 100% 🟢
src/posit/connect/oauth/oauth.py 100% 🟢
src/posit/connect/oauth/sessions.py 100% 🟢
src/posit/connect/packages.py 94% 🟢
src/posit/connect/permissions.py 100% 🟢
src/posit/connect/tasks.py 100% 🟢
src/posit/connect/users.py 97% 🟢
src/posit/connect/vanities.py 90% 🟢
src/posit/connect/variants.py 100% 🟢
TOTAL 95% 🟢

updated for commit: a1b4440 by action🐍

@tdstein
Copy link
Collaborator

tdstein commented Nov 12, 2024

This means Resource is gone and is now a read-only dictionary

I thought the goal was to merge this functionality into Resource. Or is this just an intermediate change? I see it doesn't touch Resource yet.

@schloerke
Copy link
Collaborator Author

Moving code into base branch for a full PR

@schloerke schloerke merged commit a1b4440 into schloerke/324-merge-api-and-resource Nov 14, 2024
32 checks passed
@schloerke schloerke deleted the schloerke/merge_active_and_api_dict branch November 14, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants