-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Merge Active
and ApIDictEndpoint
to ActiveDict
#331
Merged
schloerke
merged 48 commits into
schloerke/324-merge-api-and-resource
from
schloerke/merge_active_and_api_dict
Nov 14, 2024
Merged
refactor: Merge Active
and ApIDictEndpoint
to ActiveDict
#331
schloerke
merged 48 commits into
schloerke/324-merge-api-and-resource
from
schloerke/merge_active_and_api_dict
Nov 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schloerke
changed the title
Refactor: Merge
refactor: Merge Nov 12, 2024
Active
and ApIDictEndpoint
to ActiveDict
Active
and ApIDictEndpoint
to ActiveDict
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
I thought the goal was to merge this functionality into |
…rge_active_and_api_dict
Moving code into base branch for a full PR |
schloerke
merged commit Nov 14, 2024
a1b4440
into
schloerke/324-merge-api-and-resource
32 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially renaming
ApiDictEndpoint
toActiveDict
.Note: This means
Resource
is gone and is now a read-only dictionary