Add AbsolutePerformancePieChart and AbsolutePerformancePane #4295
Conversation
Pie chart shows Absolute Invested capital + Delta to show own money vs. earnings
| long[] d2 = perf.calculateAbsoluteDelta(); | ||
| wrapper.delta += d2.length > 0 ? d2[d2.length - 1] : 0L; | ||
|
|
||
| position = p.getDescription(); |
There was a problem hiding this comment.
The loop is overwriting the label multiple times. Is this intended?
It "smells" like a side effect if the loop is iteratively changing a member variable.
There was a problem hiding this comment.
Actually label is used only when it loops over 1 item (but it is not known beforehand), if there is more items, portfolio name is used as label instead.
But yes it would be better to have loop label variable in wrapper temp object.
| var dataSeries = dataSeriesSet.getAvailableSeries().stream() | ||
| .filter(ds -> ds.getType() != Type.ACCOUNT && ds.getUUID().contains(nodeId)) | ||
| .findAny().orElse(null); |
There was a problem hiding this comment.
You use the ClientSnapshot and then lookup the data series (meant for the charts).
Can't we use the ClientPerformanceSnapshot? It has the list of positions plus all the components that have been held in-between.
|
Hi @Mikerion, thanks for the contribution! I am wondering if the pie chart is the right way to visualize this information. Why? If we want to visualize it, then maybe a "waterfall" chart is more appropriate (at least that is what the German Excel calls it) 
The chart library does not support such a chart (at least to my knowledge). But I assume the math is also not too hard (no sinus and cosinus ;-). And we could render it vertically to better fit into the pane. What do you think? Apart from this, I just glanced of the code. I am wondering if the ClientPerformanceSnasphot is the easier source for the data. |
|
Hello Mikerion, buchen, waterfall would be excellent ! With maybe the option to have a detailled configuration:
|
|
Hi @buchen, main motivation was to have something similar to pie chart from https://www.calculator.net/investment-calculator.html or I've also seen it in some web app dashboard. Main thing is ratio of own money vs. "interest" so that's why pie chart is used. I'm not sure ratio is nicely visible in waterfall chart. I'm not familiar with ClientPerformanceSnasphot so I'd need to check it. |
Pie chart shows Absolute Invested capital + Delta to show own money vs. earnings