Logcontrol re-integration #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike sd-bus in libsystemd, gdbus in glib does not automatically restrict changing properties to the root user. Check the credential of the caller manually so that changes are restricted as expected. Also add more user-friendly error messages to other error conditions for a better user experience.
evverx
reviewed
Oct 31, 2024
| } | ||
|
|
||
| g_variant_get (value, "&s", &level); | ||
| polkit_backend_authority_set_log_level (level); |
There was a problem hiding this comment.
I think error handling is missing here in the sense that it accepts anything without returning errors. For example here's what systemd-resolved does:
# busctl set-property org.freedesktop.resolve1 /org/freedesktop/LogControl1 org.freedesktop.LogControl1 LogLevel "s" yolo
Failed to set property LogLevel on interface org.freedesktop.LogControl1: Invalid log level 'yolo'
# echo $?
1Here's what polkit does:
# busctl set-property org.freedesktop.PolicyKit1 /org/freedesktop/LogControl1 org.freedesktop.LogControl1 LogLevel "s" yolo
# echo $?
0There was a problem hiding this comment.
@jrybar-rh since it's still half-implemented should a new issue be opened to at least document how it interacts with --no-debug or is it going to be added to #425 (or any other PR) later?
Edit: I opened #518 so as not to forget about it.
There was a problem hiding this comment.
Fair enough. I'll collect all the shortcomings and try to document them (though I'm not a native English speaker so I'm not the best person to write the documentation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Re-commit of 79d84d0 with additional authorization check.
Detailed description and/or reproducer
Setting log level via dbus api is now restricted to root only and setting log target is disabled completely.
Fixes #506 and #507