Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(paseo): relay for identity #10651

Conversation

al3mart
Copy link
Contributor

@al3mart al3mart commented Jun 7, 2024

I have noticed several changes regarding the identity pallet, its types and how it is displayed in the app.

@validorange has reported that setting an identity was not available in the accounts tab of pjs/apps.

I believe this change should re-enable that and and use legacy identities instead of People chain ids. Please, point me in the right direction if that is not the case @TarikGul

@TarikGul
Copy link
Member

TarikGul commented Jun 7, 2024

Yea I think that should do it, thanks for the fix!

@TarikGul
Copy link
Member

TarikGul commented Jun 7, 2024

Ahh actually, there needs to be one more addition, since its a relay chain:

https://github.com/polkadot-js/apps/blob/master/packages/react-api/src/Api.tsx#L302

Needs to have paseo added to it as well. Unfortunately it's hard coded for now since everything is going to be transferred to the identity chain for all relays.

Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes the status: My bad for approving earlier

@al3mart
Copy link
Contributor Author

al3mart commented Jun 9, 2024

Thanks!

I have added a check for paseo following how the check for polkadot has been made.
Saw this at first, but was not sure if my first change was enough

@al3mart al3mart requested a review from TarikGul June 9, 2024 16:46
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, thanks for updating it!

@TarikGul TarikGul merged commit dcc8b22 into polkadot-js:master Jun 10, 2024
5 checks passed
@al3mart al3mart deleted the al3mart/fix-accounts-setidentities-paseo branch June 11, 2024 11:14
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants