Add proof size summary #10639
Merged
Add proof size summary #10639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moliholy
commented
Jun 4, 2024
|
@TarikGul any feedback? 👀 |
Yes ofcourse, sorry the extension has really been absorbing most of my time lately. I promise to have this reviewed today :) |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the proof size as a summary along with the consumed weight.
Rationale
When checking the weights, there could be occasions when one would expect a block to be fully utilized, while weight consumption is low. This is due to the fact that the PoV is quite large, since weights in V2 are two-dimensional. The main idea is to display both dimensions of the weight, and not just one.
Screenshots