-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix set identity on accounts #10581
Fix set identity on accounts #10581
Conversation
Looks like this fixes setting Identity, but there also needs to be a PR to change Identity rendering? As in, when I'm on the Relay Chain, accounts with Identity on the People Chain should still render with that Identity. |
Yea this only fixes setting the identity. The actual retrieving of the information is going to be a way larger overhaul. I don't know exactly how I am going to do it yet, but I will have a plan figured out today. Same as the above, but basically we need to keep the old while bringing in the new, so that we don't break everything for every chain that wont be using this identity structure. |
Hmm, I would not expect that, as the Identity on system chains rendered from the Relay Chain. I would expect that it just means always making a wss connection with People Chain and changing the provider of Identity info? |
Tested on both Polkadot, and westend-people and the logic works as it should. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
closes: #10580