Enable Nomination Pool Participation in Governance in Kusama #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianenigma
reviewed
Jan 13, 2025
| @@ -1859,6 +1867,11 @@ pub mod migrations { | |||
| parachains_inclusion::migration::MigrateToV1<Runtime>, | |||
| parachains_on_demand::migration::MigrateV0ToV1<Runtime>, | |||
| restore_corrupted_ledgers::Migrate<Runtime>, | |||
| // Migrate NominationPools to `DelegateStake` adapter. This is an unversioned upgrade. | |||
| pallet_nomination_pools::migration::unversioned::DelegationStakeMigration< | |||
There was a problem hiding this comment.
Fine if this is called multiple times?
There was a problem hiding this comment.
Yeah it ignores pool if already migrated.
|
Let's hype this up a bit more by renaming it to "Enable Nomination Pool Participation in Governance in Kusama"? 🙈 |
kianenigma
approved these changes
Jan 13, 2025
Ank4n
changed the title
acatangiu
approved these changes
Jan 13, 2025
franciscoaguirre
approved these changes
Jan 13, 2025
|
/merge |
fellowship-merge-bot
bot
merged commit 59802a1
into
polkadot-fellows:main
54 of 56 checks passed
|
Enabled Available commands
For more information see the documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #455.
The Polkadot changes were implemented in this PR but were reverted for Kusama. Some patches to 2409 were required before these changes can be applied to Kusama.